Clustering #30
Merged
Clustering #30
+6
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
renewiegandt
requested changes
Jan 3, 2019
| @@ -71,6 +71,8 @@ opt <- parse_args(opt_parser) | |||
| #' | |||
| #' @details If there is a header supplied other then the default data.table naming scheme ('V1', 'V2', etc.) it will be kept and extended. | |||
| #' | |||
| #' @author Hendrik Schultheis <Hendrik.Schultheis@@mpi-bn.mpg.de> | |||
There was a problem hiding this comment.
'@@' in email address
There was a problem hiding this comment.
that is necessary to escape the '@'
There was a problem hiding this comment.
Ah sorry missed that.
| @@ -35,6 +35,8 @@ opt <- parse_args(opt_parser) | |||
| #' | |||
| #' @details If there is a header supplied other then the default data.table naming scheme ('V1', 'V2', etc.) it will be kept. | |||
| #' | |||
| #' @author Hendrik Schultheis <Hendrik.Schultheis@@mpi-bn.mpg.de> | |||
There was a problem hiding this comment.
'@@' in email address
renewiegandt
approved these changes
Jan 3, 2019
Sign in
to join this conversation on GitHub.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes requested in #25.
I did the changes for reduce_sequences.R as well.